CVODE precon auto by default, improve setting deprecation error#3426
Open
mikekryjak wants to merge 1 commit into
Open
CVODE precon auto by default, improve setting deprecation error#3426mikekryjak wants to merge 1 commit into
mikekryjak wants to merge 1 commit into
Conversation
mikekryjak
force-pushed
the
cvode-precon-settings
branch
from
6033591 to
0e89e9d
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "auto prefers user (if supplied), then petsc (if available), " | ||
| "then bbd.") | ||
| .withDefault(CvodePreconMethod::none)), | ||
| .withDefault(CvodePreconMethod::auto)), |
Contributor
There was a problem hiding this comment.
warning: expected unqualified-id [clang-diagnostic-error]
.withDefault(CvodePreconMethod::auto)),
^
mikekryjak
force-pushed
the
cvode-precon-settings
branch
from
0e89e9d to
4b34adf
Compare
mikekryjak
force-pushed
the
cvode-precon-settings
branch
from
4b34adf to
6a928ba
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #3382, the setting controlling CVODE preconditioning was changed. Instead of:
The equivalent is:
The vast majority of CVODE users will have
use_precon = truein their input file because it'sfalseby default, and most applications are impossible to run without preconditioning. If they have it, they will see this error message:BOUT-dev/src/solver/impls/cvode/cvode.cxx
Lines 173 to 177 in 2772eca
But since the default is to have the preconditioner disabled, it would be more useful to tell the user how to turn it on, not to turn it off.
This PR changes the default setting to
autoon the assumption that this is preferred by the vast majority of users (let me know if this is not the case...) and also changes the error message to tell the user how to turn it on or off.