Fixes and unit tests for Field3DParallel#3428
Open
dschwoerer wants to merge 13 commits into
Open
Conversation
To make it reusable
name is a template parameter, thus cannot be used
Otherwise f.name cannot be used
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
Thanks for the tests @dschwoerer ! I've almost finished making Field3DParallel expressions lazy templates. I'll use the tests to catch regressions. |
2 tasks
ZedThree
approved these changes
Jul 10, 2026
ZedThree
left a comment
ZedThree
left a comment
Member
There was a problem hiding this comment.
LGTM, comments don't really need to be fixed
| EXPECT_TRUE(IsFieldEqual(prod, 6.0)); | ||
|
|
||
| const Field3DParallel prodpar = field.asField3DParallel() * rhs; | ||
| EXPECT_TRUE((std::is_same_v<std::decay_t<decltype(prodpar)>, Field3DParallel>)); |
Member
There was a problem hiding this comment.
std::is_same_v is a compile-time thing, so this will always be true
Comment on lines
784
to
+786
| ASSERT1_EXPR_COMPATIBLE(lhs, rhs); \ | ||
| static_assert(!std::is_same_v<L, Field3DParallel>); \ | ||
| static_assert(!std::is_same_v<R, Field3DParallel>); \ |
Contributor
|
Please hold off merging this for now. #3430 is an alternative that (I hope) will get the desired behavior while integrating Field3DParallel types into the template expressions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The templated expression broke a significant bit of the Field3DParallel implementation.
This forces to to not use the templates for Field3DParallel. It might be nice to fix them instead, but that takes more effort.
It also adds unit tests to avoid future regressions.