Fix bad PETSc cleanup#3431
Merged
Merged
Conversation
ZedThree
force-pushed
the
fix-petsc-bad-cleanup
branch
from
6002fac to
a034127
Compare
Member
Author
|
Tobias confirmed this is working for him as well |
cmacmackin
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PetscVector,PetscMatrix, andLaplacePetscwere not cleaning up their owned PETSc objects correctly, which can lead to someMPI_Comm_freeerrors on the XZ-communicator. I don't really understand exactly what the issue is, I think it's something to do with PETSc being over-eager to clean up (or not cleaning up enough?).