fix(ui): use BrowserCode v2 wordmark#97
Closed
Alezander9 wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
1 issue found across 1 file
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/ui/src/v2/components/wordmark-v2.tsx">
<violation number="1" location="packages/ui/src/v2/components/wordmark-v2.tsx:67">
P2: Left wordmark color logic is inconsistent with the muted-BROWSER requirement. Weak/shadow pixels in BROWSER currently render as currentColor.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
| y={rect.y} | ||
| width={rect.width} | ||
| height={rect.height} | ||
| fill={rect.fill === "fill" ? "var(--v2-icon-icon-muted)" : "currentColor"} |
There was a problem hiding this comment.
P2: Left wordmark color logic is inconsistent with the muted-BROWSER requirement. Weak/shadow pixels in BROWSER currently render as currentColor.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At packages/ui/src/v2/components/wordmark-v2.tsx, line 67:
<comment>Left wordmark color logic is inconsistent with the muted-BROWSER requirement. Weak/shadow pixels in BROWSER currently render as currentColor.</comment>
<file context>
@@ -1,74 +1,98 @@
+ y={rect.y}
+ width={rect.width}
+ height={rect.height}
+ fill={rect.fill === "fill" ? "var(--v2-icon-icon-muted)" : "currentColor"}
+ opacity={rect.fill === "fill" ? 0.72 : rect.fill === "weak" ? 0.2 : 0.12}
+ />
</file context>
Suggested change
| fill={rect.fill === "fill" ? "var(--v2-icon-icon-muted)" : "currentColor"} | |
| fill="var(--v2-icon-icon-muted)" |
Member
Author
|
Closing: this targeted the web/desktop v2 SVG wordmark, but the reported regression is in the terminal TUI logo. A replacement TUI-specific PR will follow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the upstream opencode v2 new-session wordmark with a BrowserCode wordmark generated from the existing TUI glyph source.\n\nChanges:\n- Render BROWSER/CODE from the same terminal glyph rows used by the CLI logo.\n- Preserve v2 watermark treatment with mask/filter.\n- Use muted color for BROWSER and currentColor for CODE.\n\nVerification:\n- bun typecheck from packages/ui\n- bun run typecheck
Summary by cubic
Replaced the v2 session wordmark with a BrowserCode wordmark built from our TUI glyphs. Keeps the v2 mask/filter treatment and uses muted color for “BROWSER” and
currentColorfor “CODE”.var(--v2-icon-icon-muted); right usescurrentColorwith tuned opacities.Written for commit d3dee28. Summary will update on new commits.