Package protan/tritan variants in the JetBrains plugin - #17
Open
bruschill wants to merge 1 commit into
Open
Conversation
Audit found every port already ships its protan/tritan source files (#12), but the JetBrains plugin only packaged the base theme: build.sh copied one .icls/.theme.json pair and plugin.xml registered a single themeProvider, so plugin installs never saw the variants. - build.sh: loop over all three variants, rewriting each editorScheme to its in-plugin path - plugin.xml: register the protan/tritan themeProviders, bump to 1.1.0 - README: reflect the bundled variants and new zip name Verified: build.sh produces a zip whose jar contains all six theme resources, each theme.json pointing at its own bundled .icls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Swept the repo for ports missing protan/tritan variants. Result: every port already ships them (#12 covered alacritty, eclipse, ghostty, helix, iterm2, jetbrains, kitty, pi, sublime (both formats), vim, vscode, web (highlight.js/prism/shiki), windows-terminal, xcode, zed).
The one real gap was packaging: the JetBrains plugin only bundled the base theme.
build.shcopied a single.icls/.theme.jsonpair andplugin.xmlregistered onethemeProvider, so anyone installing the plugin had no way to pick a colorblind-safe variant even though the source files sat right next door injetbrains/.Changes:
build.sh: loop over the three variants, copying each.iclsand rewriting each theme'seditorSchemeto its in-plugin pathplugin.xml: registercom.madeofcode.theme.protan/.tritanproviders, bump to 1.1.0, update description + change notesREADME.md: bundled-variants note, new zip name, variant pick stepVerified by running
./build.shand inspecting the zip: the jar contains all six theme resources, and eachtheme.json'seditorSchemepoints at its own bundled.icls.