Skip to content

revert(action-page): PROG-120 restore left-aligned sidebar titles #94

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bryankennedy merged 3 commits into from
Jul 13, 2026
Merged

revert(action-page): PROG-120 restore left-aligned sidebar titles #94

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbab135
revert(action-page): PROG-120 restore left-aligned sidebar titles
bryankennedy Jul 13, 2026
affc5d8
Merge branch 'main' into act/PROG-120-revert
bryankennedy Jul 13, 2026
236ce23
Merge branch 'main' into act/PROG-120-revert
bryankennedy Jul 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docs/decisions/PROG-120.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
### PROG-120 — Reverted: sidebar titles stay left-aligned

**Date:** 2026-07-13

PROG-120 originally centered every section title in the action page's right
rail (PR #92, merged). The owner judged centering the wrong move on sight and
asked for a revert the same day (PR #92's revert), restoring left-aligned
titles.

Keep in mind if restyling the rail: **don't re-center these titles.** The
revert also removed the `SIDEBAR_TITLE_CLS` constant that PR #92 introduced;
if a later change wants to unify the status-panel header and `Field` label
styles again (a v04.3-consistency idea that's still fine on its own), reintroduce
the shared constant *without* `text-center`.
12 changes: 4 additions & 8 deletions src/client/pages/ActionPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,12 +52,6 @@ const fmtTime = (iso: string) =>
const FIELD_ACTION_CLS =
"flex min-h-11 items-center text-xs text-adobe hover:underline sm:block sm:min-h-0";

// The one sidebar-title treatment (PROG-120): every section header in the
// right rail — the status panel's and each Field's — shares this string, so
// the titles can't drift apart again. Centered within the rail; the color is
// per-use (adobe for the status panel, faint ink for plain fields).
const SIDEBAR_TITLE_CLS = "text-center text-xs font-medium uppercase tracking-wide font-mono";

export default function ActionPage({
snapshot,
keyParam,
Expand Down Expand Up @@ -184,7 +178,7 @@ export default function ActionPage({
link is retired). The header names which kind of thing this page
shows: a Step is an action with a parent (PROG-106 chain). */}
<div className="rounded-lg border border-adobe-wash bg-adobe-wash/30 p-3">
<p className={`mb-2 ${SIDEBAR_TITLE_CLS} text-adobe-deep`}>
<p className="mb-2 text-xs font-medium uppercase tracking-wide font-mono text-adobe-deep">
{action.parentActionId ? "Step Status" : "Action Status"}
</p>
{/* The buttons live inside IconSelect's control column (PROG-110)
Expand Down Expand Up @@ -580,7 +574,9 @@ function CheckGlyph() {
function Field({ label, children }: { label: string; children: React.ReactNode }) {
return (
<div>
<p className={`mb-1 ${SIDEBAR_TITLE_CLS} text-ink-faint`}>{label}</p>
<p className="mb-1 text-xs font-medium uppercase tracking-wide font-mono text-ink-faint">
{label}
</p>
{children}
</div>
);
Expand Down