Feat/theme aware logo#262
Merged
Merged
Conversation
Use the beetroot hourglass mark in both color schemes: VitePress per-theme nav logo (logo-light/dark.svg) plus an adaptive prefers-color-scheme favicon (logo.svg). These variants were finalized after the design-system PR was already squash-merged, so they land here in a follow-up. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
custom.css pinned the jsDelivr import to an old landing commit (7ad5679) whose vitepress.css predates the dark-mode fix, so dark mode fell back to VitePress's default indigo brand and Inter font. Repoint to the immutable @v1.0.0 tag, which serves the corrected adapter (theme-aware brand/surfaces/fonts via raised-specificity selectors).
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the VitePress docs theme stylesheet import to reference a new upstream design-system version, presumably to pick up theme-related visual changes (e.g., for a theme-aware logo) without forking local tokens/styles.
Changes:
- Switched the shared design-system CSS import from a pinned commit SHA to the
v1.0.0ref on jsDelivr.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.