Mac OS support

[smardine]

The point is to add support for Mac OS version, for now for Rome2 only
fix #5 Scriptum button has no effect on macos

• Create a "os detection" in both all_scripted_rome2.lua and consul.lua
• in consul.lua, create a io_open method for being able to open the targeted file on both windows and macos
  linked to Scriptum button has no effect on macos #5

[smardine]

the script scriptum.lua is loading i can see the text in game.
But it remains a problem with the execute method.
when i try 2+2, there is an error message :
lua loadstring: [string "2+2"]:1: unexpected symbol near '2'

i'm pretty sure it has to be the _execute = function(cmd) at line 2740:

-- internal function to execute a command
		_execute = function(cmd)

but don't know how to handle it
here is all the files i have, hope this help
consul.zip

[bukowa]

We should first cleanup the log writing and mark it as completed. It is enough to make Consul work on Mac and maybe on Linux right? Then we can figure out best way for dealing with raw lua script files. I don't like how complicated it starts to be with detecting paths lets just stick to defaults and call it a day.

[smardine]

i made the changes, let me know

[smardine]

with the latest commit, the prebuilt scripts are working (for example exterminare) but the scriptum.lua cannot be loaded on macos because of the local success, err = pcall(dofile, script) which use the file as this without dealing with line ending.
Let me know if you want me to figure something else

[bukowa]

with the latest commit, the prebuilt scripts are working (for example exterminare) but the scriptum.lua cannot be loaded on macos because of the local success, err = pcall(dofile, script) which use the file as this without dealing with line ending. Let me know if you want me to figure something else

I can't think of anything right now as I don;'t have a Mac to test but opening and replacing line endings and using loadstring instead of dofile is the last ressort workaround I would like to avoid. I wonder if can make it work in a cleaner manner by figuring out what really happens under the hood here.

[smardine]

but opening and replacing line endings and using loadstring instead of dofile is the last ressort workaround I would like to avoid. I wonder if can make it work in a cleaner manner by figuring out what really happens under the hood here.

i found a way and it's working even for scriptum.lua and the return 2+2 test :)
no more character replacement at all :D

as supposed, it is related to the dofile method, which, on macos is sandboxed, don't know why, but it is :D
i create a method consul.io_resolve_path

io_resolve_path = function(filename)
		local sep = package.config:sub(1, 1)
		if sep ~= '\\' and consul_build == "Rome2" then
			if filename:sub(1, 1) ~= '/' then
				local home = os.getenv('HOME') or '/tmp'
				filename = home .. '/Library/Application Support/Steam/steamapps/common/Total War Rome II/' .. filename
			end
		end
		return filename
	end,

use it with the dofile method at line 3000:
local success, err = pcall(dofile, consul.io_resolve_path(script))

i use it also with io_open at line 103:

io_open = function(filename, mode, ...)
    	return io.open(consul.io_resolve_path(filename), mode, ...)
	end,

[smardine]

let me know if that's ok for you or if you need some changes :)

[bukowa]

let me know if that's ok for you or if you need some changes :)

That is great to hear !!! Clean and simple. I will have to test it for all games now locally before merging but I don't have the games installed atm. Don't worry It will get merged sorry for the time it takes but it's just not the best moment.
I wonder how it works for TOB btw.

[smardine]

let me know if that's ok for you or if you need some changes :)

That is great to hear !!! Clean and simple. I will have to test it for all games now locally before merging but I don't have the games installed atm. Don't worry It will get merged sorry for the time it takes but it's just not the best moment. I wonder how it works for TOB btw.

I don't have the TOB and the modifications has been made for rome2 only, but it should be easy to adapt 🤞