Remove stale district field from CLI output#41
Open
sepe81 wants to merge 1 commit into
Open
Conversation
sepe81
force-pushed
the
fix/issue-33-stale-district-field
branch
from
68c7a19 to
16c7e40
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
parse_resultstopped populatingd['district']in 64130d0, butpr_company_infokept printing adistricttag, so the CLI always showeddistrict: -.Relates to #33 — verified the scraper works correctly against the current handelsregister.de page structure (the underlying fix landed in #34); this just cleans up leftover dead output from that fix.
Test plan
pytest— all 18 tests passhandelsregister.py -s "cukoo GmbH"and-s "Gasag AG"against the live site and confirmed clean output