Skip to content

Coerced width and height config values to int - #1713

Open
summerisgone wants to merge 1 commit into
c3js:mainfrom
summerisgone:patch-2
Open

Coerced width and height config values to int#1713
summerisgone wants to merge 1 commit into
c3js:mainfrom
summerisgone:patch-2

Conversation

@summerisgone

Copy link
Copy Markdown

I've spent a day figuring out why tooltip isn't showing.
In c3_chart_internal_fn.tooltipPosition I got

chartRight = svgLeft + $$.currentWidth - $$.getCurrentPaddingRight();

with following values:

svgLeft = 0.5
$$.currentWidth = "800"

so I got chartRight around "0.5800".
The problem that I set width from HTML attribute as string. I think it worth nothing to cast them to int, it could saves anyone's time.

@codecov-io

Copy link
Copy Markdown

Current coverage is 64.05%

Merging #1713 into master will not change coverage

@@             master      #1713   diff @@
==========================================
  Files             1          1          
  Lines          4400       4400          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           2818       2818          
  Misses         1582       1582          
  Partials          0          0          

Powered by Codecov. Last updated by 223404a...4715f12

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants