Avoid random sort of legend - #1741
Open
EijiSugiura wants to merge 1 commit into
Open
Conversation
Accidentally order of legend are changed, when we create a graph which both of tooltip and legend are enabled. To avoid this behavior, we pass deep copy of "$$.data.targets" to orderTargets().
Current coverage is 64.04%@@ master #1741 diff @@
==========================================
Files 1 1
Lines 4400 4400
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 2818 2818
Misses 1582 1582
Partials 0 0
|
|
I'm experiencing this problem too: I can load data and then order it using an order function, but as soon as I resize the chart, the legend order changes. |
|
I am also experiencing this problem. Tested out this fix and it works for me. Would love to see this get merged soon so I don't have to use my own copy of c3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accidentally the order of legend are changed, when we create a graph which both of tooltip and legend are enabled.
To avoid this behavior, we pass deep copy of "$$.data.targets" to orderTargets().
Though it is dirty fix, but works for us.