fix: pin rollup-plugin-typescript2's include patterns explicitly - #2927
Merged
Conversation
rollup-plugin-typescript2's default include glob (*.ts+(|x)) relies on picomatch's extglob handling. picomatch >=2.3.0 changed that behavior so the pattern no longer matches .ts files, causing rollup to receive raw TypeScript source and fail with 'Unexpected token'. Passing plain include globs sidesteps the extglob pattern entirely.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rollup-plugin-typescript2's default include glob (*.ts+(|x)) relies on picomatch's extglob handling. picomatch>=2.3.0changed that behavior so the pattern no longer matches.tsfiles at all — verified locally:Without a match, rollup receives raw TypeScript source instead of the transformed output and fails with
Unexpected token. This is currently blocking #2918 (picomatch 2.2.2 → 2.3.2).Passing explicit, non-extglob include patterns sidesteps the broken interaction entirely, regardless of which picomatch version ends up resolved.