chore: upgrade docs to middleman 4.6 (was: nokogiri Ruby compat) - #2928
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
nokogiri 1.16.5 (#2895) requires Ruby >=3.0 for its precompiled native gem, which conflicted with the docs job's Ruby 2.4.10 pin. Rather than patch around that, this upgrades the whole docs toolchain:
middleman3.2.2 →~> 4.6(Ruby >=2.7). Drops the forced compass/sass/coffee-script/sprockets baggage the oldmiddlemanmeta-gem pulled in — the docs source is plain.haml+ prebuilt JS/CSS, so none of that was ever actually used. middleman-core 4.6 brings its own modernsassc/haml/kramdown.middleman-livereloadandmiddleman-sync— neither is activated inconfig.rbor invoked from any script; they were unused. Removingmiddleman-syncalso removes itsfog/fog-xmlchain, which is what pulled innokogiriin the first place — nokogiri isn't part of the dependency tree anymore at all.config.rb: dropped the:uglyhaml option (removed in Haml 6, core is unaffected otherwise —asset_hash,:source,:css_diretc. all work unchanged).Verified locally (
bundle exec middleman build) and in this PR's own CI: output structure, page count, and asset hashing all match the previous build.