Label bot traffic for analytics#649
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR reduces inflated Mixpanel page-view counts by disabling Mixpanel’s automatic pageview tracking and replacing it with a custom tracker that delays pageview emission until a first “human” interaction and skips automated browsers (via navigator.webdriver).
Changes:
- Disable Mixpanel auto pageview tracking in
main.tsxand initialize custom pageview tracking with the TanStack Router instance. - Add
initPageViewTrackinghelper to gate pageview tracking behind first interaction and de-dupe by URL. - Add Vitest/JSDOM coverage for the new tracking behavior (interaction gating, de-dupe, webdriver exclusion).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| frontend/src/main.tsx | Disables Mixpanel auto pageviews and initializes the new router-aware pageview tracking. |
| frontend/src/lib/analytics.ts | Implements interaction-gated, webdriver-filtered, de-duplicated pageview tracking. |
| frontend/src/lib/analytics.test.ts | Adds tests validating the new tracking behavior and bot filtering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+52
to
+64
| export function initPageViewTracking(router: AnyRouter): void { | ||
| if (navigator.webdriver) return | ||
| INTERACTION_EVENTS.forEach((event) => | ||
| window.addEventListener(event, confirmHuman, { | ||
| capture: true, | ||
| passive: true, | ||
| }), | ||
| ) | ||
| requestPageView() | ||
| router.subscribe("onResolved", ({ hrefChanged }) => { | ||
| if (hrefChanged) requestPageView() | ||
| }) | ||
| } |
petebachant
changed the title
petebachant
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.