feat: add SplitButton component#4998
Open
draggie wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Material Design 3 SplitButton component to React Native Paper as part of the v6 modernization effort, and wires it into the library’s exports, docs, and example app.
Changes:
- Introduces
SplitButtoncomponent implementation with size/mode tokens and styling utilities. - Adds unit tests for SplitButton rendering/handlers and several utility helpers.
- Exposes the component publicly and integrates it into docs + the example app (screen + docs config/theme color docs data).
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/index.tsx | Exports SplitButton and SplitButtonProps from the public entrypoint. |
| src/components/SplitButton/utils.ts | Adds MD3 color/shape/size helpers, ripple color derivation, and hitSlop expansion logic. |
| src/components/SplitButton/tokens.ts | Introduces SplitButton size/shape/elevation tokens. |
| src/components/SplitButton/SplitButton.tsx | Implements the SplitButton component UI, interaction handling, accessibility, and pressed-elevation/shape behavior. |
| src/components/SplitButton/index.ts | Barrel export for the new component and its props. |
| src/components/tests/SplitButton.test.tsx | Adds tests for SplitButton rendering, interaction separation, accessibility state, and several utils. |
| example/src/Examples/SplitButtonExample.tsx | Adds a SplitButton example screen with Menu-based playground and showcases. |
| example/src/ExampleList.tsx | Registers the SplitButton example in the example app’s main list. |
| docs/static/llms.txt | Adds SplitButton docs link to the LLMs index. |
| docs/src/data/themeColors.js | Adds SplitButton entries to the theme color documentation data. |
| docs/docusaurus.config.js | Registers SplitButton in the docs sidebar/config. |
Comment on lines
+40
to
+43
| export type Props = $Omit< | ||
| React.ComponentProps<typeof Surface>, | ||
| 'children' | 'mode' | ||
| > & { |
Comment on lines
+170
to
+186
| export const getSplitButtonRippleColor = ({ | ||
| contentColor, | ||
| customRippleColor, | ||
| }: { | ||
| contentColor: ColorValue; | ||
| customRippleColor?: ColorValue; | ||
| }): ColorValue | undefined => { | ||
| if (customRippleColor) { | ||
| return customRippleColor; | ||
| } | ||
|
|
||
| if (typeof contentColor !== 'string') { | ||
| return undefined; | ||
| } | ||
|
|
||
| return color(contentColor).alpha(stateOpacity.pressed).rgb().string(); | ||
| }; |
satya164
requested changes
Jun 18, 2026
satya164
left a comment
satya164
left a comment
Member
There was a problem hiding this comment.
the outline split button design doesn't seem to match the screenshots on md guidelines. they look very dark
| export const resolveSplitButtonCorner = ( | ||
| theme: InternalTheme, | ||
| key: SplitButtonShapeKey | ||
| ) => (key === 'full' ? cornerFull : (theme as Theme).shapes.corner[key]); |
| import * as React from 'react'; | ||
| import { | ||
| AccessibilityState, | ||
| Animated, |
| * export default MyComponent; | ||
| * ``` | ||
| */ | ||
| const SplitButton = forwardRef<View, Props>( |
Member
There was a problem hiding this comment.
remove forwardRef. the codebase in on react 19
though even then why does this component need ref?
| hitSlop, | ||
| trailingHitSlop, | ||
| theme: themeOverrides, | ||
| testID = 'split-button', |
Member
There was a problem hiding this comment.
don't add default test ids. such a default will leave multiple test ids and may conflict with the user's own test ids - both of which maybe confusing
Comment on lines
+388
to
+393
| const handleLeadingPressIn = React.useCallback( | ||
| (e: GestureResponderEvent) => { | ||
| onPressIn?.(e); | ||
| setPressedButton('leading'); | ||
| animateElevation(splitButtonElevation.pressed); | ||
| }, |
Member
There was a problem hiding this comment.
use reanimated shared values instead of state for animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Implements the new Material Design 3 SplitButton component as part of the v6 component modernization work.
The component provides a primary leading action and a separate trailing action for contextual options. It reuses the modernized Button API direction
from #4928/#4943: explicit
label/iconprops, MD3 mode names (filled,tonal,elevated,outlined), derived ripple/state-layer colors,extracted component tokens, size metrics, shape tokens, disabled/loading states, and separate accessibility/press handlers for each button segment.
This also adds the component to the public exports, documentation generation config, theme color docs data, and the example app. The example includes a
Menu-based playground, mode showcase, loading/disabled controls, and custom color/label styling.
Related issue
Closes #4986
Related to #4928 and #4943
Test plan
yarn lint-no-fixsrc/components/__tests__/TextInput.test.tsx.yarn typescriptyarn test --watchman=falseyarn docs buildManual verification in the example app:
SplitButtonexample screen.Sendaction and trailing menu action separately.Disabledand verify both press targets are disabled and styled correctly.Loadingand verify the leading icon is replaced with a spinner.filled,tonal,elevated, andoutlined.