Skip to content

fix: don't run checks on _dev dir#610

Merged
jahn-junior merged 5 commits into
mainfrom
work/ignore-dev-dir
Jul 10, 2026
Merged

fix: don't run checks on _dev dir#610
jahn-junior merged 5 commits into
mainfrom
work/ignore-dev-dir

Conversation

@jahn-junior

@jahn-junior jahn-junior commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator
  • Have you updated CHANGELOG.md with relevant non-documentation file changes?
    Have you updated the documentation for this change?

If you run additional checks or builds after running pa11y, any reST or MD files in _dev/node_modules/ directory are read as source and then . With this change, the checks will ignore the _dev directory.

(If you're curious, this regression was caused when we renamed .sphinx to _dev, because canonical-sphinx secretly adds .sphinx to exclude_patterns. This is why we shouldn't obfuscate configuration!)

@jahn-junior jahn-junior changed the title fix: don't run checks on dir fix: don't run checks on _dev dir Jun 16, 2026
@jahn-junior

Copy link
Copy Markdown
Collaborator Author

I'll also be using this PR to resolve #611. I'll request an additional round of reviews when ready.

@jahn-junior jahn-junior marked this pull request as ready for review July 10, 2026 22:16
@jahn-junior jahn-junior requested a review from a-velasco as a code owner July 10, 2026 22:16
@jahn-junior jahn-junior merged commit 8526180 into main Jul 10, 2026
8 checks passed
@jahn-junior jahn-junior deleted the work/ignore-dev-dir branch July 10, 2026 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants