Skip to content

Enable non zero round BFT bootstrap#6392

Open
adetokunbo wants to merge 10 commits into
adetokunbo/cip-104-switch-make-traffic-based-app-rewards-the-test-defaultfrom
adetokunbo/cip-104-enable-non-zero-round-bootstrap
Open

Enable non zero round BFT bootstrap#6392
adetokunbo wants to merge 10 commits into
adetokunbo/cip-104-switch-make-traffic-based-app-rewards-the-test-defaultfrom
adetokunbo/cip-104-enable-non-zero-round-bootstrap

Conversation

@adetokunbo

Copy link
Copy Markdown
Contributor

Fixes #6110

This is stacked on #6000 which contains the fix for the title portion of #6110
The is PR addresses the extended portion mentioned in this comment

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

@adetokunbo
adetokunbo requested a review from dfordivam July 13, 2026 08:24
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from 0dc0ae0 to c18b220 Compare July 13, 2026 08:52
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-switch-make-traffic-based-app-rewards-the-test-default branch from 89d6100 to d28d776 Compare July 13, 2026 08:56
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from c18b220 to 05b25d9 Compare July 13, 2026 08:58
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-switch-make-traffic-based-app-rewards-the-test-default branch from d28d776 to c976dd0 Compare July 15, 2026 06:31
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from 05b25d9 to e10c1a0 Compare July 15, 2026 06:32
@adetokunbo
adetokunbo requested a review from dfordivam July 15, 2026 06:33
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from e10c1a0 to 6300b73 Compare July 15, 2026 06:47
@adetokunbo

adetokunbo commented Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

@dfordivam PTAL

Note that the new test runs quickly, faster than TrafficBasedRewardsTimeBasedIntegrationTest

Although it specifically tests the behavior in the presence of an extra SV, isn't it also covering the basic BFT multi-SV functionality that that test currently checks?

If so, to reduce overall integration testing latency, (and thereby reduce the chance of future flakes), should this PR also switch TrafficBasedRewardsTimeBasedIntegrationTest back to being a single SV test?

@adetokunbo adetokunbo self-assigned this Jul 15, 2026
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from 6300b73 to 78019c1 Compare July 15, 2026 07:01
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-switch-make-traffic-based-app-rewards-the-test-default branch from d8947f0 to 3e919eb Compare July 16, 2026 06:25
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch 2 times, most recently from 9ea9c04 to 746710e Compare July 16, 2026 06:37
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
…tionTest

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
Signed-off-by: Tim Emiola <adetokunbo@emio.la>
…dIntegrationTest

Signed-off-by: Tim Emiola <adetokunbo@emio.la>
@adetokunbo
adetokunbo force-pushed the adetokunbo/cip-104-enable-non-zero-round-bootstrap branch from 5cc9a15 to 02ef27c Compare July 16, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants