Skip to content

Final Implementation Initiate Proposal Flow#6410

Draft
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:puneetfinoa/sv-ui/2623
Draft

Final Implementation Initiate Proposal Flow#6410
timpel-fcs wants to merge 1 commit into
canton-network:mainfrom
Finoa-Consensus-Services:puneetfinoa/sv-ui/2623

Conversation

@timpel-fcs

Copy link
Copy Markdown
Contributor

Summary

This PR adds Initiate Proposal layout changes that are not covered by the component issues references in the parent issue:

  • Align Initiate Proposal flow with Figma: shared layout tokens (createProposalLayout.ts), card/field column sizing, and InitiateProposalLayout wrapper.
  • Restyle form CTAs and Cancel Proposal dialog via formButtonStyles and CancelProposalDialog (Figma pill buttons, discard confirmation).
  • Refactor governance forms and review step: FormLayout, ProposalReviewField, updated ProposalSummary / ConfigValuesChanges, review-only header on create flow.
  • Add WeightDiffIndicator for SV reward-weight changes on initiate and review steps.
  • Fix config row label overlap, FormLayout spacing, and update governance form/summary tests.

Fixes #2623

Figma: https://www.figma.com/design/sXdsHZtM5c7xXQWckd6Ob8/supervalidator?node-id=0-1

Pull Request Checklist

Cluster Testing

  • If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
  • If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

  • Include any change that might be observable by our partners or affect their deployment in the release notes.
  • Specify fixed issues with Fixes #n, and mention issues worked on using #n
  • Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

  • Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

Signed-off-by: Tim Pelzer <tim.pelzer@finoa.io>
@timpel-fcs

Copy link
Copy Markdown
Contributor Author

this is a draft, pending merge of the interlinked component changes for final look and feel + layout review of the initiate proposal flow

Before merging of all other components no review is required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SV UI Redesign Look & Feel: Page: Governance (Initiate proposal)

5 participants