Compute informees uniformly#6412
Merged
julientinguely-da merged 9 commits intoJul 17, 2026
Merged
Conversation
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
julientinguely-da
marked this pull request as ready for review
July 16, 2026 09:15
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…ulien/6127-unifom-informees-computation
moritzkiefer-da
approved these changes
Jul 16, 2026
moritzkiefer-da
left a comment
moritzkiefer-da
left a comment
Contributor
There was a problem hiding this comment.
thx definitely an improvement, left a few suggestions where we can maybe improve things even further
| ).map(PartyId.tryFromProtoPrimitive), | ||
| getInformees(allocation) :+ | ||
| PartyId.tryFromProtoPrimitive( | ||
| svTaskContext.dsoStore.key.dsoParty.partyId.toProtoPrimitive |
Contributor
There was a problem hiding this comment.
should we just make getInformees include the dso party and filter it out in the one case where we don't need it (I think complleteWithIgnoredAmuletVersionCheck)? that seems less fragile
Contributor
Author
There was a problem hiding this comment.
We also have ExpireRewardCouponV2Trigger, ExpiredAmuletAllocationV2Trigger
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
…ulien/6127-unifom-informees-computation
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
| fallback: => Future[TaskOutcome] | ||
| )(implicit ec: ExecutionContext): Future[TaskOutcome] = { | ||
| // ensure we do not ignore the DSO party itself, even if it is unresponsive | ||
| val expiredOwners = stakeholders - dsoParty |
Contributor
Author
There was a problem hiding this comment.
FYI doing it explicitly in the guard itself to avoid wrong usages
julientinguely-da
enabled auto-merge (squash)
July 16, 2026 13:35
julientinguely-da
disabled auto-merge
July 16, 2026 13:37
julientinguely-da
enabled auto-merge (squash)
July 16, 2026 13:38
Signed-off-by: Julien Tinguely <julien.tinguely@digitalasset.com>
julientinguely-da
disabled auto-merge
July 17, 2026 05:57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6127
Pull Request Checklist
Cluster Testing
/cluster_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./upgrade_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./hdm_teston this PR to request it, and ping someone with access to the DA-internal system to approve it./lsu_teston this PR to request it, and ping someone with access to the DA-internal system to approve it.PR Guidelines
Fixes #n, and mention issues worked on using#nMerge Guidelines