UI tests janitorization

[pawelperek-da]

Among the other things
Fixes https://github.com/DACH-NY/cn-test-failures/issues/9237

Complete list of changes:

1. user.click no longer hides behind waitFor

• Why? It's an antipattern: see https://github.com/testing-library/eslint-plugin-testing-library/blob/main/docs/rules/no-wait-for-side-effects.md. Basically user.click has it's own waiting behaviour which is more robust than waitFor's

2. Replaced getAttribute('disabled').toBeDefined with getAttribute('disabled').not.toBeNull

• Why? getAttribute('disabled') returns null when false and "" when true. and toBeDefined checks only for !== undefined, hence it's always producing true and false positives

3. Replaced not.toBe([]) with .not.toHaveLength(0)

• Why? not.toBe([]) compares an array with newly created [] so it's always true

Pull Request Checklist

Cluster Testing

• If a cluster test is required, comment /cluster_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If an upgrade test is required, comment /upgrade_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If a hard-migration test is required (from the latest release), comment /hdm_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.
• If a logical synchronizer upgrade test is required (from canton-3.5), comment /lsu_test on this PR to request it, and ping someone with access to the DA-internal system to approve it.

PR Guidelines

• Include any change that might be observable by our partners or affect their deployment in the release notes.
• Specify fixed issues with Fixes #n, and mention issues worked on using #n
• Include a screenshot for frontend-related PRs - see README or use your favorite screenshot tool

Merge Guidelines

• Make the git commit message look sensible when squash-merging on GitHub (most likely: just copy your PR description).

[OriolMunoz-da]

re-request review when it passes CI 😄

[pawelperek-da]

@isegall-da could you take a look at those errors? are they related to the artifactory nuke?

[isegall-da]

@isegall-da could you take a look at those errors? are they related to the artifactory nuke?

Yes, they definitely are. I don't understand how it passed CI on my PR then 🤔

[isegall-da]

@isegall-da could you take a look at those errors? are they related to the artifactory nuke?

Yes, they definitely are. I don't understand how it passed CI on my PR then 🤔

I think you're just not based on the latest main. Can you rebase?

[pawelperek-da]

ah 🤦 let me try that

[OriolMunoz-da]

ty

should we add lints for all these?

[pawelperek-da]

Yeah, sounds good, I'll leave it for the tech debt though