Skip to content

Various Doctest Fixes#1101

Merged
henrydingliu merged 17 commits into
mainfrom
doctest_fix
Jul 10, 2026
Merged

Various Doctest Fixes#1101
henrydingliu merged 17 commits into
mainfrom
doctest_fix

Conversation

@henrydingliu

@henrydingliu henrydingliu commented Jul 10, 2026

Copy link
Copy Markdown
Member

Summary of Changes

Fixing previously un-executed failing doctests

Related GitHub Issue(s)

#1089

Additional Context for Reviewers

the doctest setup itself is not modified in this PR, only the doctests themselves. the same changes are also pushed to #1091, and passes actual execution

  • I passed tests locally for both code (uv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)

Note

Low Risk
Documentation-only edits to doctest blocks; no application logic or public API behavior changes.

Overview
Updates docstring doctests so they match actual output when executed via the docs doctest builder (#1089). No runtime or test-setup logic changes.

Common.pipe — adds the missing expected triangle printout for the loc[..., 48:] example.

ClarkLDF — switches omega_ / theta_ rounding from 3 to 2 decimals and refreshes the expected grouped LOB table layout.

IBNR methods (Benktander, BornhuetterFerguson, Chainladder, CapeCod) — small doctest hygiene: remove stray blank lines in testcode, assign intermediates before print where needed, and fix Sphinx directives (.. testoutput:: instead of .. testoutput:).

Reviewed by Cursor Bugbot for commit a568e33. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

Copy link
Copy Markdown

Pyright Type Completeness

View the full pyright --verifytypes output for this commit

Project (full chainladder package, at this PR's head): 14.7% of exported symbols fully typed (184 / 1252)

Known Ambiguous Unknown Total
Project (head) 184 106 962 1252

Other symbols referenced but not exported by chainladder: 13

Known Ambiguous Unknown Total
Other (head) 3 1 9 13

Symbols without documentation:

  • Functions without docstring: 313
  • Functions without default param: 0
  • Classes without docstring: 10

Patch (exported symbols added or changed by this PR): no exported symbol type-completeness changes detected.

@codecov

codecov Bot commented Jul 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (c45d10b) to head (a568e33).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1101      +/-   ##
==========================================
+ Coverage   90.06%   90.43%   +0.36%     
==========================================
  Files          91       91              
  Lines        5287     5299      +12     
  Branches      671      676       +5     
==========================================
+ Hits         4762     4792      +30     
+ Misses        370      361       -9     
+ Partials      155      146       -9     
Flag Coverage Δ
unittests 90.43% <ø> (+0.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@henrydingliu henrydingliu merged commit 990dc9e into main Jul 10, 2026
18 checks passed
@henrydingliu henrydingliu deleted the doctest_fix branch July 10, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants