[TEST] Adding coverage#1105
Merged
Merged
Conversation
Pyright Type CompletenessView the full Project (full
Other symbols referenced but not exported by
Symbols without documentation:
Patch (exported symbols added or changed by this PR): 0.0% fully typed (0 / 2)
Patch symbol details
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1105 +/- ##
==========================================
+ Coverage 90.48% 90.50% +0.01%
==========================================
Files 91 91
Lines 5289 5289
Branches 671 671
==========================================
+ Hits 4786 4787 +1
Misses 359 359
+ Partials 144 143 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
genedan
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
a couple of tests for if statements
Related GitHub Issue(s)
#1088
Additional Context for Reviewers
doctest in
disposal_rate_tridoes not get executed because properties are excludeduv run pytest) and documentation changes (uv run jb build docs --builder=custom --custom-builder=doctest)Note
Low Risk
Small behavioral guard in disposal_rate_tri plus tests and docstring cleanup; no auth or critical infrastructure changes.
Overview
Adds pytest coverage for
disposal_rate_trion a full Chainladder triangle (ultimate disposal rate equals 1) and onDisposalRateoutput withsample_weight(early development columns stay NaN when weights apply).Triangle.disposal_rate_trinow appliesdisposal_w_only when its shape matches the working triangle, mirroring thelink_ratio/w_pattern and avoiding incorrect broadcasting when shapes differ.The property’s doctest block was removed because property examples are not executed by the doc test builder.
Reviewed by Cursor Bugbot for commit d5d6c66. Bugbot is set up for automated code reviews on this repo. Configure here.