Fix timeline playhead alignment and scroll-on-select#58
Merged
Conversation
Position media blocks on the render plan time axis so the red playhead tracks thumbnails when durations change, and only auto-scroll during playback. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RenderPlanstart frames (same time axis as the red playhead and audio lane) instead of cumulative packed layout — fixes drift after duration changes.currentFrameon thumbnail seek so the playhead moves immediately.Closes #57
Test plan
pnpm test/pnpm lint/pnpm buildMade with Cursor