Conversation
Coverage Report for CI Build 28640812998Coverage decreased (-0.8%) to 87.638%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions137 previously-covered lines in 4 files lost coverage.
Coverage Stats
💛 - Coveralls |
Using the pattern matching lets type checkers prove that all branches are taken (using the latest unreleased params library)
This is a prety major change, the core merge_fq routine now finds the point to change in terms of actual dataset coordinates, these include: * N_PROF * N_LEVELS * CDOM_WAVELENGTHS (if it has CDOM) * Any other new coordinates we might have (urls) A lot of the merge fq machinery focuses on turing the EXPOCODE, STNNBR, CASTNO, SAMPNO, etc... into coordinates that xarray understands. This should allow the changing of anything in the file except expanding/shrinking variable dims. Even if the variable doesn't have a WHP Name, it can be addressed by variable name. This should include expocode, station, cast, sample if they are addressed by variable name.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the creation of string type ancillary variables of various shapes that can be attached to primary variables. The intent for now is to link to external data sets and not to, for example, methods papers or documentation.
TODO: