2 fixes#1802
Conversation
| engine_logger.info( | ||
| f"Running {len(rules)} rules against {len(datasets)} datasets" | ||
| ) | ||
| if len(rules) == 0: |
There was a problem hiding this comment.
The check is happening after the engine_logger has already logged length of the rules, that would show running 0 rules against number of datasets. It also happens after the datasets has been loaded/converted to parquet if needed. With zero rules it will just end up getting aborted. If we move this check a bit higher, it can help save extra work done on datasets.
| f"Running {len(rules)} rules against {len(datasets)} datasets" | ||
| ) | ||
| if len(rules) == 0: | ||
| raise ValueError( |
There was a problem hiding this comment.
From the content of the error message it seems the intention is to print one line instead of full trace. But raise ValueError here will actually print whole python trace as it is not caught or handled anywhere in this file or core.py file. If full trace is intentional please let me know.
There was a problem hiding this comment.
@RamilCDISC i think a stacktrace here is fine. It will be 2 lines core.py -> run_validation then the actual log.
3 participants
this PR fixes 2 issues found in the test data--
removes 1 QA test that was not executing any rules and was now returning an error; added unit test