Updates to project#1
Open
winterheart wants to merge 12 commits into
Open
Conversation
Set cmake_minimum_required to 3.24 as current CMake-4 not supporting <3.5. Use new features that provides 3.24: CMAKE_COMPILE_WARNING_AS_ERROR, CMAKE_POSITION_INDEPENDENT_CODE, and others. Enforce C++14 standard. Add various configuration options for convenience: * LIB7ZIP_ENABLE_TESTING - enables building testing programs * LIB7ZIP_WARNING_AS_ERROR - enforce CMAKE_COMPILE_WARNING_AS_ERROR Formatting code and cleanup.
CPP/7zip/Common/FileStreams.h requires additional code from 7zip. Otherwise, compilation will fail with "undefined reference to `vtable for COutFileStream'" and "undefined reference to `NC::NFile::NIO::CFileBase::Close()'" errors.
Fix -Winconsistent-missing-override compilation failure.
Copying (U)Int64 types definitions from 7zip header. This allows to use and install lib7zip independently of 7zip sources.
Build only one type of library (STATIC/SHARED) at same time. In order to get both types users should use CMake Presets or MultiConfig generators.
Add CI pipeline for build testing.
Fixing building on Windows platform.
Use "%hs" for wprintf() on wstring. Use "%lld" for wprintf() on UInt64 types.
Convert input TCHAR* parameter into std::string.
lib7zip not ready yet for Windows DLL linking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
Here some changes to enhance project.