perf(push_child): defer unparent until evaluation

[ernisto]

No description provided.

[Olaroll]

Did a quick test with this. Improves my performance a lot, but I did encounter a new error for some reason. I'll leave the traceback, in case it helps. I can try looking into what specific type of graph causes the issue later today. It's a specific source update where it happens consistently, but all other sources seem fine ¯\_(ツ)_/¯

Also I'm using alicesaidhi's fork with types, but I hope that's not relevant because the graph code is pretty much unchanged compared to centau's.

Here's the traceback:

ReplicatedStorage.Src.Packages..pesde.alicesaidhi+vide.0.4.1-testing.4.vide.src.graph:105: invalid argument #1 to 'find' (table expected, got nil)  -  Client - graph:105
Stack Begin  -  Studio
Script 'ReplicatedStorage.Src.Packages..pesde.alicesaidhi+vide.0.4.1-testing.4.vide.src.graph', Line 105 - function evaluate_node  -  Studio - graph:105
Script 'ReplicatedStorage.Src.Packages..pesde.alicesaidhi+vide.0.4.1-testing.4.vide.src.graph', Line 271 - function update_descendants  -  Studio - graph:271
Script 'ReplicatedStorage.Src.Packages..pesde.alicesaidhi+vide.0.4.1-testing.4.vide.src.source', Line 24 - function update_source  -  Studio - source:24
Script 'ReplicatedStorage.Src.UI.UiUtils', Line 34  -  Studio - UiUtils:34
Stack End  -  Studio

[ernisto]

how did u merge them ? id like see exactly the code. I will take a look here, but would be useful a minimal repro

[ernisto]

probably this is the minimal repro of the error you get there, but there maybe you have a condition before the infinite re-entrancy happen

[ernisto]

@Olaroll

[ernisto]

@centau let me know if i should remove this long comment, or any format adjust

[Olaroll]

Hey @ernisto, finally got time to make a repro for the error I had. It could probably be simplified further, but I think this is enough to get you on the right track. Also, this time I tested with the the main repo Vide, your code exactly, and the issue is still present.

Vide.root(function()
	local currentTime = Vide.source(time())
	RunService.Heartbeat:Connect(function() currentTime(time()) end)

	local tblSrc = Vide.source({})
	local i = 0
	local function addItem()
		i += 1
		local tbl = tblSrc()
		tbl[`Entry{i}`] = "Hello There"
		tblSrc(tbl)
	end

	Vide.cleanup(task.spawn(function()
		while task.wait(1) do
			addItem()
		end
	end))

	Vide.effect(function() print(tblSrc()) end)

	Vide.indexes(tblSrc, function(_v, k)
		local function removeThis()
			local tbl = tblSrc()
			tbl[k] = nil
			tblSrc(tbl)
		end

		local finishedAt = currentTime() + 0.5
		local isFinished = Vide.derive(function() return currentTime() >= finishedAt end)

		Vide.effect(function()
			if isFinished() then removeThis() end
		end)
	end)
end)

[ernisto]

the commit i made yesterday doesnt really fix the issue, just make clearer the real issue

[ernisto]

  	local tbl = tblSrc()
  	tbl[k] = nil
  	tblSrc(tbl)

vide doesnt have deep equal table check, so it does the infinite re-entrant updates. Even on vide almost sure it will error stack overflow, so for your specific case, you could fix this by using

local tbl = vide.untrack(tblSrc)
tbl[k] = nil
tblSrc(tbl)

[Olaroll]

Oh right, can't believe I missed the untrack there 🤦

In that case, I'm more surprised by my code not erroring on the main branch.