Skip to content

ci: fail release if gem manifest is out of date#127

Merged
cb-alish merged 2 commits into
masterfrom
ci/verify-gem-manifest-on-release
Jul 2, 2026
Merged

ci: fail release if gem manifest is out of date#127
cb-alish merged 2 commits into
masterfrom
ci/verify-gem-manifest-on-release

Conversation

@cb-alish

@cb-alish cb-alish commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

The release workflow built the gem directly without regenerating the s.files manifest in chargebee.gemspec. When new files were added but the manifest was not updated, they were silently excluded from the published gem. Add a step that runs make update-manifest and fails the release if chargebee.gemspec differs, preventing missing build artifacts.

Release workflow now regenerates the gem manifest before publishing and fails if chargebee.gemspec is out of date. This ensures the committed s.files list matches the generated manifest, preventing missing files from being omitted from the packaged gem.

The release workflow built the gem directly without regenerating the
s.files manifest in chargebee.gemspec. When new files were added but the
manifest was not updated, they were silently excluded from the published
gem. Add a step that runs `make update-manifest` and fails the release if
chargebee.gemspec differs, preventing missing build artifacts.

Co-authored-by: Cursor <cursoragent@cursor.com>
@snyk-io

snyk-io Bot commented Jul 2, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 122c36c8-cec2-49ef-a073-72db9082d803

📥 Commits

Reviewing files that changed from the base of the PR and between 869476d and 126ea7a.

📒 Files selected for processing (1)
  • .github/workflows/release.yml

Walkthrough

Adds a CI step to the Ruby release workflow that runs make update-manifest and checks chargebee.gemspec for uncommitted diffs, failing the job with diagnostic output if stale, otherwise confirming the manifest is current before gem build/push.

Changes

Release Workflow Manifest Check

Layer / File(s) Summary
Add gemspec verification step
.github/workflows/release.yml
New step runs make update-manifest, diffs chargebee.gemspec, fails with diagnostic diff output on drift, otherwise logs manifest is current.

Estimated code review effort: 1 (Trivial) | ~3 minutes


Comment @coderabbitai help to get the list of available commands.

@cb-alish cb-alish merged commit d53682b into master Jul 2, 2026
10 checks passed
@cb-alish cb-alish deleted the ci/verify-gem-manifest-on-release branch July 2, 2026 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants