ci: fail release if gem manifest is out of date#127
Merged
Conversation
The release workflow built the gem directly without regenerating the s.files manifest in chargebee.gemspec. When new files were added but the manifest was not updated, they were silently excluded from the published gem. Add a step that runs `make update-manifest` and fails the release if chargebee.gemspec differs, preventing missing build artifacts. Co-authored-by: Cursor <cursoragent@cursor.com>
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
WalkthroughAdds a CI step to the Ruby release workflow that runs ChangesRelease Workflow Manifest Check
Estimated code review effort: 1 (Trivial) | ~3 minutes Comment |
cb-muthiahm
approved these changes
Jul 2, 2026
cb-karthikp
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release workflow built the gem directly without regenerating the s.files manifest in chargebee.gemspec. When new files were added but the manifest was not updated, they were silently excluded from the published gem. Add a step that runs
make update-manifestand fails the release if chargebee.gemspec differs, preventing missing build artifacts.Release workflow now regenerates the gem manifest before publishing and fails if
chargebee.gemspecis out of date. This ensures the committeds.fileslist matches the generated manifest, preventing missing files from being omitted from the packaged gem.