chore: remove vestigial exports, types, and constants (#233)#250
Merged
Conversation
Dead-code sweep. Each symbol below was verified to have zero references across packages, scripts, apps/web, tests, and workflows (excluding dist/): - transformer: USLM_NAMESPACE, LEGAL_LIST_MARKERS, OUTPUT_PATH_PATTERN constants; PreserveOrderTextNode/ElementNode/Node types (parser/transformer do their namespace and node walking without them). - transformer: extractText — a "for backward compatibility" shim with no remaining callers; production code uses extractTextFromNodes. Its tests are removed with it. - fetcher: allTitlesXmlUrl — the all-titles archive is never fetched; only per-title downloads (titleXmlUrl) are used. - scripts: HashedFile interface — buildManifest uses an inline literal. Barrels updated to drop the removed re-exports. The getAttributes / getAttrsFromNode transformer duplication is intentionally left untouched. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #233.
Dead-code sweep. A read-only reconnaissance pass grepped every
exported symbol acrosspackages/*/src,scripts/,apps/web, tests, and.github/workflows (excludingdist/). Each symbol removed below had zero references beyond its own definition (and barrel re-export).Removed
USLM_NAMESPACE,LEGAL_LIST_MARKERS,OUTPUT_PATH_PATTERNbuildSectionPath's own templatePreserveOrderTextNode/PreserveOrderElementNode/PreserveOrderNodetypesmixed-content.test.tsdefines its own localPreserveOrderNodeextractText(+ its tests)extractTextFromNodesallTitlesXmlUrltitleXmlUrldownloads are usedHashedFileinterfacebuildManifestuses an inline{ path, content }literal insteadBarrels (
transformer/src/index.ts,fetcher/src/index.ts) updated to drop the removed re-exports.Deliberately left alone
getAttributes/getAttrsFromNodetransformer duplication (intentional, out of scope per the issue).@civic-source/typesexports (PrecedentImpact,ReleasePointSchema) — low-confidence, kept.Verification
Local
pnpm build && pnpm typecheck && pnpm lint && pnpm test— all green (build 6/6, typecheck 8/8, lint 6/6, test 8/8). Removing the symbols breaks nothing because nothing referenced them.🤖 Generated with Claude Code