Support Option values in index filters#4949
Conversation
|
Hi @Mr-Dust0 , please see the docs here about why this is more work than it may first appear: https://github.com/clockworklabs/SpacetimeDB/pull/4024/changes#diff-3ce7e5c02154d19ebe0624a457ea8b0c30a6b1658a24856ed1ea2ec3ee28916a. |
04b404e to
9d7547d
Compare
9d7547d to
b789158
Compare
|
Hi @bfops, I’ve updated the PR to cover the additional work you shared in the docs. The changes I've made add TypeScript module-side support for indexed/unique optional columns, keep non-filterable option types rejected at compile time, and normalize null/undefined option-none comparisons in the TypeScript table cache. I also kept the Rust and C# coverage in place. |
…le-option # Conflicts: # crates/lib/src/filterable_value.rs
|
I've added some additional automated tests in #5448 . I was unable to figure out how to make GitHub's UI set that PR to target your branch, so merging these might be a bit of a hassle, but we'll figure it out. We'll need to do a bit more work on our end to make the tests pass, and then we'll get back to you. |
Summary
Fixes #4824.
Test Plan