fix(project): bump extension projects to the latest runner (LITE-33583)#254
Draft
pcaro wants to merge 1 commit into
Draft
Conversation
`bump` selected the runner image by the Connect platform major, which is obsolete now that the runner follows its own semver line — it silently picked a stale image. Use the latest published runner instead, matching the bootstrap behavior. Bumping only the docker images would recreate the bootstrap dependency mismatch on existing projects (new runner, stale pyproject pins), so bump now also rewrites the `python` and `connect-eaas-core` entries in [tool.poetry.dependencies] with the specifiers derived from the runner's PyPI metadata. The rewrite is line-level to preserve the file's formatting, and dev-dependencies are left untouched. Drop the now-unused get_pypi_runner_version_by_connect_version().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to @qarlosh's comment on #252.
Problem
ccli project extension bumpselected the runner image by the Connect platform major (get_pypi_runner_version_by_connect_version()). Now that the runner follows its own semver line, that lookup silently picks a stale image.Fix
bumpnow uses the latest published runner, same as bootstrap.pythonandconnect-eaas-coreentries in[tool.poetry.dependencies]with the specifiers derived from the runner's PyPI metadata. Line-level rewrite — file formatting and dev-dependencies untouched. Skipped if the project has nopyproject.toml.get_pypi_runner_version_by_connect_version()(no remaining users).Verification
test_bump_runner_versionnow also asserts the pyproject pins get updated and dev-deps stay untouched.