fix(mcp): recover expired HTTP sessions#1923
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: be0bdce The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
mattzcarey
force-pushed
the
fix/mcp-stale-session-self-heal
branch
from
July 22, 2026 10:24
72bc65b to
e3fae6f
Compare
When discovery receives HTTP 404 on a restored streamable HTTP session, clear the stale id from memory and storage, initialize a new session, and discover once. Keep application-level 404 errors and fresh-session failures unchanged.
mattzcarey
force-pushed
the
fix/mcp-stale-session-self-heal
branch
from
July 22, 2026 10:25
e3fae6f to
be0bdce
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Recover a streamable HTTP MCP connection when the server returns HTTP 404 for a session restored from storage.
The client now:
Application-level JSON-RPC errors with code 404 are unchanged, as are failures on sessions negotiated in the current lifetime.
Why this is needed
The MCP SDK skips
initializewhen given a persisted session id. If the server expires that session while the Agent sleeps, restore appears connected but discovery remains wedged on 404 across later wakes.The regression still reproduces on current
main; the new session-lifecycle test fails there and passes with this fix.Validation
pnpm --filter agents exec vitest run src/tests/mcp— 30 files, 548 tests passedpnpm run checkpasses through exports, formatting, lint, andpackages/agentstypechecks; repo-wide typecheck is currently blocked by unchangedmainvoice errors inexamples/voice-agentandvoice-providers/assemblyaiIncludes a patch changeset for
agents.