fix(mcp): harden connection recovery#1924
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 94d0911 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
Honor retry budgets when connectToServer returns a failed result, drain old-id connection work before stable-id migration, and close connections replaced by the legacy connect path.
mattzcarey
force-pushed
the
fix/mcp-reconnect-hardening
branch
from
July 22, 2026 10:34
f1ac7be to
94d0911
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Harden three supported MCP connection-recovery paths:
connectToServer()reports{ state: "failed" }instead of throwing;connect()path and clear its terminated persisted session id.Why this is needed
tryN()only retries thrown errors, while MCP connection failures normally resolve as a failed result. Documented retry options therefore stopped after one attempt. Stable-id migration could also rename a connection while restore still addressed the old id, orphaning discovery. Finally, the internally-used legacy reconnect path dropped replaced transports without closing them.The minimized regression tests still fail on current
mainfor all three symptoms and pass with this branch.Validation
pnpm --filter agents exec vitest run src/tests/mcp— 30 files, 553 tests passedmainvoice errors inexamples/voice-agentandvoice-providers/assemblyaiIncludes a patch changeset for
agents.