fix(release): remove stale agent-think preview pins#1970
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
agent-thinkapp's same-repositoryagents,@cloudflare/ai-chat, and@cloudflare/thinkdependencies from the old observability preview toworkspace:*pkg.pr.newentriesagent-think/AGENTS.mdto describe the workspace dependency modelWhy
The release workflow fails when
.github/changeset-version.tsregenerates the lockfile. The pinned@cloudflare/thinkpreview tarball contains transitive URL dependencies on preview builds such as@cloudflare/shell; pnpm 11'sblockExoticSubdepsprotection rejects those withERR_PNPM_EXOTIC_SUBDEP.The observability implementation from the pinned preview has since merged into the monorepo, so the preview pins are no longer needed. Resolving these packages from the workspace removes the exotic transitive dependency graph and continues to work when Changesets bumps package versions.
Failed release: https://github.com/cloudflare/agents/actions/runs/29930875361/job/88960249979
Verification
CI=true pnpm install --frozen-lockfilepnpm --filter @cloudflare/agent-think test(39 tests)pnpm run build(25 projects)pnpm run check(all 117 TypeScript projects).github/changeset-version.tsrelease command in a disposable clone; lockfile regeneration passed after producingagents@0.18.0,@cloudflare/ai-chat@0.9.4,@cloudflare/think@0.14.0, and@cloudflare/shell@0.4.2No changeset: this fixes private app dependency wiring and the release process; it does not change a published package API.