Add API Token migration path and Service Key deprecation callout to …#32206
Open
baubuchon-cf wants to merge 1 commit into
Open
Add API Token migration path and Service Key deprecation callout to …#32206baubuchon-cf wants to merge 1 commit into
baubuchon-cf wants to merge 1 commit into
Conversation
…Keyless SSL setup
Contributor
Review
Fix in your agentFix the following review findings in PR #32206 (https://github.com/cloudflare/cloudflare-docs/pull/32206).
Before making changes, review each finding and present a brief summary table:
- For each finding, state whether you agree, disagree, or need clarification
- If you disagree (e.g. the fix requires disproportionate effort for minimal benefit,
or the finding is factually incorrect), explain why
- If you need clarification before deciding, ask those questions
- Then share your plan for which issues to tackle and in what order
After triaging, fix all legitimate findings. For any you decide to skip,
post a comment on this PR with the finding ID and your reasoning.
---
## Style Guide Review
### Warnings (1)
#### SG-dfbbd9f9519d · Bold product/credential name
- **File:** `src/content/partials/ssl/keyless-key-server-setup.mdx` line 145
- **Issue:** Line bolds `API Token` as the credential name
- **Fix:** Use `API Token` in regular text or `api_token` in monospace when referring to the config field.
### Suggestions (2)
#### SG-37b3bed21b8e · Time-sensitive content
- **File:** `src/content/partials/ssl/keyless-key-server-setup.mdx` line 156
- **Issue:** Line contains the date `September 30, 2026` outside changelog content
- **Fix:** Remove or rewrite without the month and year unless the exact deadline is required.
#### SG-2ab0e7b6504e · Time-sensitive content
- **File:** `src/content/partials/ssl/keyless-key-server-setup.mdx` line 155
- **Issue:** Admonition title contains the date `September 30, 2026`
- **Fix:** Remove or rewrite without the month and year unless the exact deadline is required.
Code ReviewThis code review is in beta and may not always be helpful — use your judgment. No code review issues found. ConventionsNo convention issues found. Style Guide ReviewWarnings (1)
Suggestions (2)
CommandsOnly codeowners can run commands. Post a comment with the command to trigger it.
|
Contributor
|
This pull request requires reviews from CODEOWNERS as it changes files that match the following patterns:
|
Contributor
|
Nimbus Preview URL: https://nimbus-40ce1b90.preview.developers.cloudflare.com |
Contributor
|
Preview URL: https://40ce1b90.preview.developers.cloudflare.com |
lgarofalo
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds API Token (recommended) and deprecation callout for Origin CA Service Keys
to the Keyless SSL key server setup partial, which renders on both the Public DNS
and Cloudflare Tunnel configuration pages.
Why
gokeyless v1.18.0 (July 7, 2026) shipped API Token support for server certificate
enrollment (PR #563). Origin CA Service Keys are being removed September 30, 2026
(AUTHN-180). The docs currently only document the deprecated Service Key path with
no mention of the deadline or the migration.
What changed
Verification
/ssl/keyless-ssl/configuration/cloudflare-tunnel/ via shared partial
Related: SHIP-15399, AUTHN-180, SECENG-13851