feat(banner): adjust banner colors and add size + actions props#628
Open
najlaskr wants to merge 1 commit into
Open
feat(banner): adjust banner colors and add size + actions props#628najlaskr wants to merge 1 commit into
najlaskr wants to merge 1 commit into
Conversation
commit: |
Contributor
Docs PreviewCommit: |
Contributor
mattrothenberg
requested changes
Jul 11, 2026
mattrothenberg
left a comment
Collaborator
There was a problem hiding this comment.
Love the visuals here, the after screenshots are a major improvement! A few things before merging:
- I think Banner.Actions is the wrong API: it's just a flex div, and since it has exactly one correct usage it adds boilerplate for every consumer. The Banner root could probably apply that layout to the action slot itself.
- Relatedly, Banner.Action is a parallel fork of Button (its own size table, variant names, and focus styles, and the sizes already diverge from KUMO_BUTTON_VARIANTS despite the comment saying they mirror it). Open question: is Button's forced !text-white the only blocker to reusing it? If so I'd rather fix that in Button than maintain a second button that will drift.
- Third, the theme changes rewrite global tokens (--color-kumo-warning, the *-tint family, etc.) that toast, badge, and command palette also consume, so this changes more than banners while testing only covers banners. Was this change intentional? Am I misreading the diff?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







































Fixes muddy CTA colors that washed out against banner backgrounds, adjust banner hues for better contrast and adds new size options.
Banner.ActionsCTA compound to allow specific-styling for action buttons without affecting existingButtonstyles.Banner.Actionsupportsprimary(filled),secondary(accent-hued outline on a transparent background), andghostvariantssizeprop toBanner("base"|"sm"); the compact"sm"size suits dialogs and other tight spaces and defaults itsBanner.Actionchildren to thexssizeBefore
After
pnpm lint,pnpm typecheckandpnpm test