Skip to content

antlr4.yaml: Add g4 language#55

Open
Dhiraj240 wants to merge 1 commit into
coala:masterfrom
Dhiraj240:antlr4
Open

antlr4.yaml: Add g4 language#55
Dhiraj240 wants to merge 1 commit into
coala:masterfrom
Dhiraj240:antlr4

Conversation

@Dhiraj240

Copy link
Copy Markdown
Member

Closes #27

Comment thread data/Language/antlr4.yaml Outdated
- catch
- finally
- mode
- options

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing spaces (trailing-spaces)

Origin: YAMLLintBear, Section: yaml.

@jayvdb

jayvdb commented Nov 29, 2018

Copy link
Copy Markdown
Member

@gitmate-bot rebase

@jayvdb

jayvdb commented Nov 29, 2018

Copy link
Copy Markdown
Member

Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently ⚠️

@jayvdb

jayvdb commented Nov 29, 2018

Copy link
Copy Markdown
Member

Automated rebase with GitMate.io was successful! 🎉

@jayvdb jayvdb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

many more keywords , especially the very important 'skip' mentioned in https://github.com/antlr/antlr4/blob/master/doc/lexer-rules.md#lexer-commands

@corona10

corona10 commented Dec 2, 2018

Copy link
Copy Markdown

@jayvdb
Yes, they should be

@Dhiraj240

Copy link
Copy Markdown
Member Author

@jayvdb Alright, i will push changes once i get a break in between my exams.

Comment thread data/Language/antlr4.yaml
- g4
line_continuation:
- backslash
delimiters:

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suppose we have a rule delimiter ; as well. And lines are assumed to continue over any whitespace unless a rule delimiter is encountered.
example rule:

genericAssocList
    :   genericAssociation
    |   genericAssocList ',' genericAssociation
    ;

Although I haven't seen the statement delimiter mentioned in most of the languages, probably a useful thing to include ? (most new languages use a semicolon, but some older ones use newlines / full stops as well)

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems practical, will add this too.

@jayvdb

jayvdb commented Dec 14, 2018

Copy link
Copy Markdown
Member

Comment on 44ebd02, file data/Language/Pascal.yaml, line 53.

truthy value is not quoted (truthy)

Origin: YAMLLintBear, Section: yaml.

@jayvdb

jayvdb commented Dec 14, 2018

Copy link
Copy Markdown
Member

Comment on 44ebd02, file data/Language/VisualBasic.yaml, line 5.

line too long (82 > 80 characters) (line-length)

Origin: YAMLLintBear, Section: yaml.

@jayvdb

jayvdb commented Dec 14, 2018

Copy link
Copy Markdown
Member

Comment on 44ebd02, file data/Language/VisualBasic.yaml, line 98.

truthy value is not quoted (truthy)

Origin: YAMLLintBear, Section: yaml.

@Dhiraj240

Copy link
Copy Markdown
Member Author

@jayvdb Now its good to go.Also, sorry for being late my exams are over now and i am free from everything.Now the "code like crazy" mode will begin. 😄

@utkarsh2102 utkarsh2102 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments inline.

Comment thread data/Language/antlr4.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

5 participants