loc-justify: apply cut-list - #53
Merged
Merged
Conversation
…field, no-op guards - ErrNetResizeUnsupported + marker + isNetResizeUnsupported: no production branch checks the sentinel and the NIC-drop path is gated to CH already; cocoon's CLI output still surfaces in the wrapped error - Runtime.Image is a presence probe: return error only, drop the write-only Image struct - evictPod: every call site passes a non-empty reason literal - dropVMLocked/clearRuntimeAnnotations: delete() is a spec-guaranteed no-op on missing keys and nil maps - indexOrphanByName: sole call chain passes &vms[i], never nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies the cut-list from the whole-repo LOC-justify audit (follow-up to #52). Behavior-preserving; each cut was adversarially verified against complete call-site enumeration:
ErrNetResizeUnsupported+ detection marker +isNetResizeUnsupported: no production branch checks the sentinel (errors.Isonly appeared in a test), and the NIC-drop path is already gated to cloud-hypervisor; cocoon's CLI output still surfaces in the wrapped error. The now-duplicate unsupported-flavor hibernate test folds into the generic-error test.Runtime.Imagebecomes an error-only presence probe; theImagestruct's single field was write-only (both callers discard the value).evictPod'sreason != ""branch: all five call sites pass non-empty literals.dropVMLocked/clearRuntimeAnnotationsdelete-guards:delete()is a spec-guaranteed no-op on missing keys and nil maps.indexOrphanByNamenil check: the only call chain passes&vms[i].Gates: golangci-lint 0 issues (linux+darwin), asl clean (linux+darwin),
go test -race ./...green. Net −51 lines.