Skip to content

feat: -f/--format flag with strict msgpack rejection#38

Closed
rahlk wants to merge 1 commit into
feat/issue-29-analyzer-manifestfrom
feat/issue-30-format-flag
Closed

feat: -f/--format flag with strict msgpack rejection#38
rahlk wants to merge 1 commit into
feat/issue-29-analyzer-manifestfrom
feat/issue-30-format-flag

Conversation

@rahlk

@rahlk rahlk commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Closes #30. Part of epic #26 (contract-correctness cluster).

Stacked PR 4 of 7 — base: feat/issue-29-analyzer-manifest; review this PR's diff in isolation. Merge the stack bottom-up into feat/issue-2-program-graphs.

Verified: full suite 99 pass / 0 fail, typecheck clean, schema.neo4j.json in lockstep. Reviewed (task-scoped + final whole-branch review: READY TO MERGE).

msgpack is a recognized-but-unimplemented value: it must exit non-zero
with a clear message, never silently fall back to json. Unknown values
are likewise rejected, mirroring the existing --emit validation style.
@rahlk

rahlk commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Dropped per maintainer decision: msgpack output has no consumers, and json is already the sole/default output — so a -f/--format flag (which existed only to expose json|msgpack and reject the unimplemented msgpack) is vestigial. The commit was rebased out of the stack; PR #39 (#31) now bases directly on #29 (#28).

@rahlk rahlk closed this Jul 7, 2026
@rahlk rahlk deleted the feat/issue-30-format-flag branch July 7, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant