feat(installer): config and vault primitives for multiple data centers - #623
Open
NJona wants to merge 2 commits into
Open
feat(installer): config and vault primitives for multiple data centers#623NJona wants to merge 2 commits into
NJona wants to merge 2 commits into
Conversation
Adds what a multi-data-center installation needs from the config and vault types, without any behaviour change for existing callers: - InstallVault.RemoveSecret and InstallVault.Clone, so a vault can be derived from another one instead of generated from scratch. - RootConfig.Clone, a YAML round-trip deep copy. - The installer's dataCenters and defaultDataCenterId keys, which declare the topology of the installation. Both are omitempty, so a single-data-center config serialises exactly as before. - InstallConfigManager.SetInstallConfig/SetVault, so a caller can seed a manager from another source than a profile or a file. - files.PostgresUserSecretName/PostgresPasswordSecretName, so the per-service postgres secret names have one definition. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Jona Neef <Jona.Neef.97@gmail.com>
Signed-off-by: NJona <25478046+NJona@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Groundwork for multi-data-center support, with no behaviour change for existing callers.
InstallVault.RemoveSecretandInstallVault.Clone, so a vault can be derived from another one instead of generated from scratch.RootConfig.Clone, a YAML round-trip deep copy.dataCentersanddefaultDataCenterIdkeys, which declare the topology of the installation. Both areomitempty, so a single-data-center config serialises exactly as before.InstallConfigManager.SetInstallConfig/SetVault, so a caller can seed a manager from a source other than a profile or a file.files.PostgresUserSecretName/PostgresPasswordSecretName, so the per-service postgres secret names have a single definition.Review notes
Nothing consumes any of this yet — it is all additive.
Part of the
oms beta bootstrap-gcp --multi-dcstack (10 PRs). Merge in order; each PR is based on its predecessor.