Address Python course review feedback - #98
Merged
Conversation
Use the published cross-repository course URL explicitly and hide decorative card icons from assistive technology.
There was a problem hiding this comment.
Pull request overview
Follow-up to the Python 101 teaching-page addition, tightening accessibility and link clarity for the CoMPhy Python 101 course card.
Changes:
- Mark the two decorative Font Awesome icons in the Python 101 course card as
aria-hidden="true". - Replace the relative course link with the explicit published URL (
https://comphy-lab.org/comphy-python101/) to remove cross-repo Pages ambiguity.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #97:
The two dead-link comments on #97 were duplicates and the route was already live as a separate project Pages deployment; the absolute URL removes the ambiguity for future static review.
Verification
npm test -- --runInBand— 12 suites, 77 tests passedhttps://comphy-lab.org/comphy-python101/— HTTP 200