-
Notifications
You must be signed in to change notification settings - Fork 2
fix(orders): tighten shipping address, line, and item schema constraints #121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
leofischer
wants to merge
10
commits into
release/v2.3.0
Choose a base branch
from
fix/shipping-address-validation-schema
base: release/v2.3.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
1bef7cd
fix(orders): tighten shipping address, line, and item schema constraints
leofischer 0408554
fix(orders): tighten shipping address, line, and item schema constraints
leofischer 95e2f09
fix: align checkout, order, card and bnpl schemas with enforced valid…
leofischer 56cd670
fix: apply adversarial-review corrections to checkout, order and meta…
leofischer cd48bb9
fix: describe unsupported metadata value types as contract, not enfor…
leofischer 8a4a4b2
fix: apply second adversarial-review pass corrections
leofischer 4f726df
fix: regenerate _build/api.yaml with redocly and align make merge wit…
leofischer 321fafe
chore: regenerate _build/api.yaml after rebase onto release/v2.3.0
leofischer 48c60f8
fix: regenerate bundle with openapi-generator to match updated CI check
leofischer 60544bd
fix(bnpl): cancel_url and expires_at are nullable
leofischer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,21 +3,20 @@ allOf: | |
| - $ref: './customer_payment_method_request.yml' | ||
| - type: object | ||
| required: | ||
| - can_not_expire | ||
| - cancel_url | ||
| - failure_url | ||
| - product_type | ||
| - success_url | ||
| - type | ||
| properties: | ||
| cancel_url: | ||
| type: string | ||
| description: "URL to redirect the customer after a canceled payment" | ||
| type: [string, "null"] | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. creo que openapi toma todos los nO requeridos como nullable, entonces no abría falta agregar, al contrarío si agregamos acá el nullable, en los generators enviaran nullable en vez de omitir los campos |
||
| description: "Optional URL to redirect the customer after a canceled payment" | ||
| example: "https://example.com/cancel" | ||
| can_not_expire: | ||
| type: boolean | ||
| example: true | ||
| description: "Indicates if the payment method can not expire" | ||
| expires_at: | ||
| type: [integer, "null"] | ||
| format: int64 | ||
| example: 1680397724 | ||
| description: "Optional expiry for the BNPL order, expressed in seconds since the Unix epoch. Defaults to one month from creation when omitted." | ||
| failure_url: | ||
| type: string | ||
| description: "URL to redirect the customer after a failed payment" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| title: shipping_contact_address | ||
| type: object | ||
| description: "Address of the person who will receive the order" | ||
| properties: | ||
| street1: | ||
| type: string | ||
| minLength: 2 | ||
| maxLength: 249 | ||
| example: Nuevo Leon 254 | ||
| description: "Street and number of the delivery address." | ||
| street2: | ||
| type: string | ||
| maxLength: 249 | ||
| example: Departamento 404 | ||
| description: "Apartment, suite or interior reference for the delivery address." | ||
| postal_code: | ||
| type: string | ||
| maxLength: 250 | ||
| example: "06100" | ||
| description: "Postal code of the delivery address. For Mexican addresses (country MX) it must be a 5-digit postal code." | ||
| city: | ||
| type: string | ||
| maxLength: 249 | ||
| pattern: "[A-Za-z]{2}" | ||
| example: "Ciudad de Mexico" | ||
| description: "City of the delivery address. Must contain at least two consecutive ASCII letters." | ||
| state: | ||
| type: string | ||
| maxLength: 249 | ||
| example: "Ciudad de Mexico" | ||
| description: "State of the delivery address." | ||
| country: | ||
| type: string | ||
| minLength: 2 | ||
| maxLength: 249 | ||
| example: MX | ||
| description: "Country of the delivery address. This field follows the [ISO 3166-1 alpha-2 standard](https://en.wikipedia.org/wiki/ISO_3166-1_alpha-2)." | ||
| residential: | ||
| type: [boolean, "null"] | ||
| default: true | ||
| example: true | ||
| description: "Indicates whether the delivery address is residential." |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.