Chore: remove stale ML-pin comments in pyproject.toml#55
Merged
Conversation
The two comments in `concepts-ml` (`pyproject.toml`) were written when torch 2.2 was the resolved version and warned about numpy 2.x ABI breaks and a transformers 5.x NameError. Both were torch-2.2-specific. On main today, pip resolves torch 2.12, sentence-transformers 5.6, transformers 5.12, and numpy 2.4 — concepts-ml CI passes against that combination. The comments now mislead more than they help; the pins themselves are preserved as belt-and-braces.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
concepts-mlcomments intools/extractors/pyproject.tomlthat warned about torch 2.2 — both behaviors they describe (numpy 2.x ABI break, transformers 5.x NameError) were specific to torch 2.2.concepts-mlCI job exercises the full embedding pass against that resolution and is green.Why now
Confirmed in the post-merge run of #50 (Extractors run): the resolved versions exceed what either comment described by ~10 minor releases, and CI passes. Future readers were going to keep stumbling on "torch 2.2" framing.
Test plan
markdown,yaml,crosswalk-schemagreen on this PRconcepts-mlalready green on main with the relaxed pins (run 28477800714)