fix: use matchDepNames in Renovate package rules to pin prev_major_version to v3#520
Conversation
matchPackageNames matches the registry packageName ("coreruleset/coreruleset"),
not the depName set by depNameTemplate. This meant the allowedVersions: "<4.0.0"
constraint was never applied to prev_major_version, allowing Renovate to propose
v4 updates for that field.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Renovate configuration updates the ChangesRenovate config update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying website with
|
| Latest commit: |
22c7dcb
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://c8370f22.website-1u6.pages.dev |
| Branch Preview URL: | https://fix-renovate-prev-major-vers.website-1u6.pages.dev |
Summary
matchPackageNameswithmatchDepNamesin both Renovate package rulesrangeStrategy: bump-minorfrom the v3 rule (no effect on pinned versions)Problem
matchPackageNamesmatches the registrypackageName, which is"coreruleset/coreruleset"for both custom managers. It never matched"coreruleset-v3"or"coreruleset-v4"(those aredepNamevalues set bydepNameTemplate). As a result, theallowedVersions: "<4.0.0"constraint was silently ignored, and Renovate would propose v4 updates forprev_major_version.matchDepNamesmatchesdepName, which is what the custom managers actually set — fixing the constraint.Test plan
prev_major_versionprev_major_versionlatest_major_version🤖 Generated with Claude Code
Summary by CodeRabbit