upgrade prometheus 3.9.1#7535
Open
SungJin1212 wants to merge 6 commits into
Open
Conversation
f1a535a to
e675cf9
Compare
e675cf9 to
06fc626
Compare
540cedf to
d763c33
Compare
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
d763c33 to
8c8d384
Compare
friedrichg
reviewed
Jun 21, 2026
| // evaluate each lazy matcher against the relevant label value. A per-matcher, | ||
| // per-value cache avoids running the same regex against the same string more | ||
| // than once, which is particularly effective when many series share label values. | ||
| func (c *blocksPostingsForMatchersCache) fetchWithLazyMatchers(ctx context.Context, ix tsdb.IndexReader, selectMs, lazyMs []*labels.Matcher) ([]storage.SeriesRef, int64, error) { |
Member
There was a problem hiding this comment.
I would be nice to see how the benchmark changes with this change
go test -bench=BenchmarkIngester_LazyPosting -benchmem -run=^$ -count=5 ./pkg/ingester/...
Not a blocker since, this flag is experimental.
Maybe @alanprot can also chime in here
| // Wait until a run has been completed on each compactor | ||
| for _, c := range compactors { | ||
| cortex_testutil.Poll(t, 120*time.Second, true, func() any { | ||
| cortex_testutil.Poll(t, 240*time.Second, true, func() any { |
Member
There was a problem hiding this comment.
Is this absolutely necessary? why is it taking longer now?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the Prometheus version to 3.9.1
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]docs/configuration/v1-guarantees.mdupdated if this PR introduces experimental flags