Skip to content

upgrade prometheus 3.9.1#7535

Open
SungJin1212 wants to merge 6 commits into
cortexproject:masterfrom
SungJin1212:update-prometheus-3.9.1
Open

upgrade prometheus 3.9.1#7535
SungJin1212 wants to merge 6 commits into
cortexproject:masterfrom
SungJin1212:update-prometheus-3.9.1

Conversation

@SungJin1212

@SungJin1212 SungJin1212 commented May 21, 2026

Copy link
Copy Markdown
Member

Upgrade the Prometheus version to 3.9.1

Which issue(s) this PR fixes:
Fixes #

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]
  • docs/configuration/v1-guarantees.md updated if this PR introduces experimental flags

@SungJin1212 SungJin1212 marked this pull request as draft May 21, 2026 11:26
@dosubot dosubot Bot added dependencies Pull requests that update a dependency file go Pull requests that update Go code labels May 21, 2026
@SungJin1212 SungJin1212 force-pushed the update-prometheus-3.9.1 branch 10 times, most recently from f1a535a to e675cf9 Compare May 29, 2026 10:43
@SungJin1212 SungJin1212 force-pushed the update-prometheus-3.9.1 branch from e675cf9 to 06fc626 Compare June 1, 2026 08:20
@SungJin1212 SungJin1212 marked this pull request as ready for review June 4, 2026 02:30
@SungJin1212 SungJin1212 force-pushed the update-prometheus-3.9.1 branch from 540cedf to d763c33 Compare June 4, 2026 12:28
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
Signed-off-by: SungJin1212 <tjdwls1201@gmail.com>
@SungJin1212 SungJin1212 force-pushed the update-prometheus-3.9.1 branch from d763c33 to 8c8d384 Compare June 19, 2026 06:07

@friedrichg friedrichg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this

// evaluate each lazy matcher against the relevant label value. A per-matcher,
// per-value cache avoids running the same regex against the same string more
// than once, which is particularly effective when many series share label values.
func (c *blocksPostingsForMatchersCache) fetchWithLazyMatchers(ctx context.Context, ix tsdb.IndexReader, selectMs, lazyMs []*labels.Matcher) ([]storage.SeriesRef, int64, error) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be nice to see how the benchmark changes with this change

  go test -bench=BenchmarkIngester_LazyPosting -benchmem -run=^$ -count=5 ./pkg/ingester/... 

Not a blocker since, this flag is experimental.

Maybe @alanprot can also chime in here

// Wait until a run has been completed on each compactor
for _, c := range compactors {
cortex_testutil.Poll(t, 120*time.Second, true, func() any {
cortex_testutil.Poll(t, 240*time.Second, true, func() any {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this absolutely necessary? why is it taking longer now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file go Pull requests that update Go code size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants