fix(gcc): silence GCC CI false positives (-Wmaybe-uninitialized, -Wtsan)#293
Merged
Merged
Conversation
GCC mis-analyzes the structured-binding-from-co_await idiom (auto [ec, ...] = co_await op) inside coroutine frames and reports a bogus -Wmaybe-uninitialized. The pattern is the core async API and is used by most async tests, so suppress it for GCC across the test project (the library itself is warning-clean). Mirrors capy. Also wrap the two POSIX scheduler post_handler acquire fences (reactor_scheduler, io_uring_scheduler) with the existing -Wtsan suppression macros. TSan cannot instrument standalone fences; these acquire fences pair with the posting thread's release and are intentional. They compile only on Linux, so they slipped past every non-tsan job and failed solely under GCC 15 + -fsanitize=thread, matching the suppression already applied in continuation_op.hpp.
|
An automated preview of the documentation is available at https://293.corosio.prtest3.cppalliance.org/index.html If more commits are pushed to the pull request, the docs will rebuild at the same URL. 2026-06-30 16:24:17 UTC |
|
GCOVR code coverage report https://293.corosio.prtest3.cppalliance.org/gcovr/index.html Build time: 2026-06-30 16:36:04 UTC |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC mis-analyzes the structured-binding-from-co_await idiom (auto [ec, ...] = co_await op) inside coroutine frames and reports a bogus -Wmaybe-uninitialized. The pattern is the core async API and is used by most async tests, so suppress it for GCC across the test project (the library itself is warning-clean). Mirrors capy.
Also wrap the two POSIX scheduler post_handler acquire fences (reactor_scheduler, io_uring_scheduler) with the existing -Wtsan suppression macros. TSan cannot instrument standalone fences; these acquire fences pair with the posting thread's release and are intentional. They compile only on Linux, so they slipped past every non-tsan job and failed solely under GCC 15 + -fsanitize=thread, matching the suppression already applied in continuation_op.hpp.