fix: make RAG file-type detection case-insensitive#6487
Open
xbrxr03 wants to merge 1 commit into
Open
Conversation
Uppercase/mixed-case extensions (.PDF, .Docx, .CSV) were silently misrouted to the text loader instead of the correct parser, causing binary content to be embedded into the RAG store. Lowercase the path before matching against the extension map so that Report.PDF resolves to PDF_FILE, data.CSV to CSV, etc. Closes crewAIInc#6399
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesExtension matching fix
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6399
Problem:
DataTypes.from_content()uses case-sensitivepath.endswith(ext)against a lowercase-only extension map. Files with uppercase/mixed-case extensions (.PDF,.CSV,.DOCX) are silently misrouted to the text loader, causing raw binary bytes to be chunked and embedded into the RAG store instead of parsed document text.Fix: Lowercase the path before extension matching:
Before:
report.PDFtext_filepdf_filedata.CSVtext_filecsvdoc.DOCXtext_filedocxAfter: All resolve correctly regardless of case.
This is a single-line change with no behavioral impact for already-correct lowercase paths.
AI-assisted: written with the help of an AI coding agent (OpenClaw/GlM-5.1).