fix(tools): raise ToolUsageError instead of bare raise in _original_tool_calling#6511
Open
Aakash326 wants to merge 1 commit into
Open
fix(tools): raise ToolUsageError instead of bare raise in _original_tool_calling#6511Aakash326 wants to merge 1 commit into
Aakash326 wants to merge 1 commit into
Conversation
…ool_calling Fixes crewAIInc#6430. The bare 'raise' in the non-dict-arguments branch of _original_tool_calling had no active exception to re-raise, so Python raised 'RuntimeError: No active exception to re-raise' instead of a meaningful ToolUsageError. Replaced it with an explicit 'raise ToolUsageError(...)' matching the sibling return statement and the pattern used elsewhere in this method. Co-authored-by: Cursor <cursoragent@cursor.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughChangesTool argument error handling
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6430.
The bare
raisein the non-dict-arguments branch of_original_tool_callinghad no active exception to re-raise, so Python raised
RuntimeError: No active exception to re-raiseinstead of a meaningfulToolUsageError. Replaced it with an explicitraise ToolUsageError(...)matching the sibling
returnstatement and the pattern used elsewhere inthis method.
Added regression test covering both
raise_error=Trueandraise_error=Falsepaths.