Fix shellcheck violations

[straight-shoota]

No description provided.

[Copilot]

Pull request overview

This PR focuses on addressing ShellCheck warnings across the repository’s shell scripts (release tooling, packaging helpers, and Docker smoke tests) primarily by improving quoting, safer reads, and more explicit sourcing/command invocation patterns.

Changes:

• Quote variable expansions/paths and tighten argument handling (read -r, quoted URLs/globs, safer rm, etc.).
• Adjust script sourcing patterns and ShellCheck directives (e.g., SC1091, shellcheck source=/dev/null).
• Update Docker smoke test script and Docker command invocations to reduce ShellCheck violations.

Reviewed changes

Copilot reviewed 19 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
snapcraft/crystal-snap-wrapper	Quotes SNAP paths and simplifies env-check execution.
processes/scripts/prepare-shards-release.sh	Uses read -r, safer sourcing path, quotes, and minor string handling tweaks.
processes/scripts/prepare-crystal-release.sh	Uses read -r, safer sourcing path, quotes, and minor string handling tweaks.
processes/scripts/make-shards-release.sh	Quotes tag/changelog paths and updates sourcing path.
processes/scripts/make-crystal-release.sh	Quotes tag/changelog paths and updates sourcing path.
processes/scripts/functions.sh	Adds shebang, switches to printf, updates START_STEP logic and arithmetic.
processes/scripts/download-crystal-release-artifacts.sh	Quotes $1 check and changes artifact listing output.
packages/test-install-on-docker.sh	Quotes mounts/image name and changes how extra args are forwarded.
packages/support/test-install.sh	Fixes argument quoting when calling install script.
packages/scripts/install.sh	Adds ShellCheck source hints and quotes some URLs.
packages/obs-release.sh	Quotes docker env/paths and makes globbing explicit with ./*.spec/./*.dsc.
packages/obs-push.sh	Makes globbing explicit and hardens rm -r path safety.
packages/obs-new-minor.sh	Quotes docker env/paths, makes globbing explicit, and quotes obs-release invocation args.
omnibus/package-scripts/crystal/prerm	Modernizes uname checks with $(...) and &&.
omnibus/package-scripts/crystal/postinst	Modernizes uname checks with $(...) and &&.
omnibus/package-scripts/crystal/makeselfinst	Reworks variable assignment/quoting and hardens rm -rf target.
linux/test.sh	Quotes docker bind-mount path.
docker/smoke.sh	Switches to bash, fixes regex quoting, and adjusts llvm-config discovery.
docker/apply-latest-tags.sh	Quotes tag arguments for docker buildx imagetools.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 19 out of 19 changed files in this pull request and generated 1 comment.