notification feature#31
Merged
Merged
Conversation
naasanov
requested changes
Jul 3, 2026
Comment on lines
+12
to
+14
| "engines": { | ||
| "node": "24" | ||
| }, |
Collaborator
There was a problem hiding this comment.
Node 24 is not a supported version for cloud functions as per Firebase docs https://firebase.google.com/docs/functions/manage-functions#set-node.js
|
|
||
| // function to save the fcmtoken to firestore | ||
| // used by cloud function to send push notifications to the correct device | ||
| Future<void> _saveTokenToFirestore() async { |
Collaborator
There was a problem hiding this comment.
FCM tokens never get cleared on signout, so a user will continue getting notifications for their account even after they've signed out
Comment on lines
+110
to
+112
| // used by cloud function to send push notifications to the correct device | ||
| Future<void> _saveTokenToFirestore() async { | ||
| final uid = FirebaseAuth.instance.currentUser?.uid; |
Collaborator
There was a problem hiding this comment.
Fails with the following logs. Likely due to missing push notifs capability in xcode configuration. Need to add in Xcode -> Runner -> Signing & Capabilities -> + Capability
flutter: FCM token attempt 1 failed: [firebase_messaging/apns-token-not-set] APNS token has not been received on the device yet. Please ensure the APNS token is available before calling `getAPNSToken()`.
flutter: FCM token attempt 2 failed: [firebase_messaging/apns-token-not-set] APNS token has not been received on the device yet. Please ensure the APNS token is available before calling `getAPNSToken()`.
flutter: FCM token attempt 3 failed: [firebase_messaging/apns-token-not-set] APNS token has not been received on the device yet. Please ensure the APNS token is available before calling `getAPNSToken()`.
flutter: FCM token attempt 4 failed: [firebase_messaging/apns-token-not-set] APNS token has not been received on the device yet. Please ensure the APNS token is available before calling `getAPNSToken()`.
flutter: FCM token attempt 5 failed: [firebase_messaging/apns-token-not-set] APNS token has not been received on the device yet. Please ensure the APNS token is available before calling `getAPNSToken()`.
flutter: Could not get FCM token after retries
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#28